fossasia / sphinx_fossasia_theme

Theme for Sphinx/Yaydoc

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add a base templating HTML structure

imujjwal96 opened this issue · comments

Description

Add a base templating HTML structure for the theme similar to Sphinx's built in base theme.
Without inheriting any theme and using structure same as that used by the base Sphinx theme will be a good learning curve and will help to extend it as per our needs

Update: After discussion, it is decided that we will instead inherit from the basic theme. As @pri22296 pointed out, From the sphinx docs:

The inherit setting gives the name of a “base theme”, or none. The base theme will be used to locate missing templates (most themes will not have to supply most templates if they use basic as the base theme), its options will be inherited, and all of its static files will be used as well.

Parent issue: #3

@imujjwal96 Are you sure you wanna go the inherit = none way? Every custom theme seems to inherits from basic. Even the built-in themes inherit from basic.

I'm open to suggestions. it's just about the feasibility. I've also been doing some research about that. If things don't seem to work, I'll go with inheriting the base.

Ok. So let's work with inheriting the basic theme then.

It's just that I couldn't find any other theme which doesn't inherits from basic.
From the sphinx docs:

The inherit setting gives the name of a “base theme”, or none. The base theme will be used to locate missing templates (most themes will not have to supply most templates if they use basic as the base theme), its options will be inherited, and all of its static files will be used as well.

It's seem inheriting from basic just helps us avoid doing redundant stuff

Close this then?