Improve tests

Question

Improve tests

mariobehling opened this issue 8 years ago · comments

As mentioned elsewhere by @rhemon

it would better if you could improve the tests. such as testing if results collected are matching a pattern or not? also it might be more organised if you had each of the classes in different files. and have all of the tests in a tests directory. you will see lot of repositories follow this pattern. try a larger coverage increase.
... it should only be concentrating on rss-generator.py but there are other files part of it as well. we might need to look into that.

Bikram Bharti · Answer 1 · Fri Feb 03 2017 16:21:02 GMT+0800 (China Standard Time)

@rhemon should I start writing tests, I have throughly tested the working I am ready to add tests :) Also I would like to discuss, more thorough testing, as in right now we are only testing if we are getting response with non-zero length, is it enough?

Ridhwanul Haque · Answer 2 · Fri Feb 03 2017 16:28:57 GMT+0800 (China Standard Time)

@In-vincible yes please go ahead and add tests. u can ask for help anytime. once you add the tests u thought of, do a Pull Request. if we think something else can be added or changed we can mention it there.

Bikram Bharti · Answer 3 · Fri Feb 03 2017 16:45:37 GMT+0800 (China Standard Time)

Cool! so I should add tests in tests.py only?

Ridhwanul Haque · Answer 4 · Fri Feb 03 2017 23:34:43 GMT+0800 (China Standard Time)

@In-vincible you can do that, or else if you want you can have a test folder containing a TestSuite and different test cases (each with its own file) for the different search engines used, also for the other helper function used.

Bikram Bharti · Answer 5 · Mon Feb 06 2017 14:16:43 GMT+0800 (China Standard Time)

I have added tests for duckduckgo and askcom, I am into adding tests for generateFeed function should I give a PR at this stage for discussion purpose?

Bikram Bharti · Answer 6 · Mon Feb 06 2017 14:18:05 GMT+0800 (China Standard Time)

Also I would love to do lots of other scraping, I am aware with selenium as well, do we have any more plans for searss @mariobehling @rhemon

Bikram Bharti · Answer 7 · Mon Feb 06 2017 14:22:26 GMT+0800 (China Standard Time)

Should we add unittest-xml module for XML testing?

Ridhwanul Haque · Answer 8 · Mon Feb 06 2017 17:13:31 GMT+0800 (China Standard Time)

yes you can do a PR so that we can discuss. and it would be good if you use unittest xml, i think this will be needed to reach 100% coverage and i would say you can go ahead and add whatever you want to searss and do a PR for that. then we can discuss and improve that as well. or if you want first create a issue for the feature u want to add. we discuss there first and then you can add?

Bikram Bharti · Answer 9 · Mon Feb 06 2017 20:09:52 GMT+0800 (China Standard Time)

Okay I am putting up the PR, while locally I have am setting up the unittest-xml for testing the xml patterns, we will discuss the xml things on the PR then :)