Add unit tests

Question

Add unit tests

bessman opened this issue 4 years ago · comments

Alexander Bessman commented 4 years ago

PSL lacks unit tests. I'm interested in writing them, if you think they would be useful to the project.

Add unit tests for Peripherals
Add unit tests for achan
Add units tests for analyticsClass
Add unit tests for commands_proto
Add unit tests for digital_channel
Add unit tests for packet_handler
Add unit tests for sciencelab
Add unit tests for sensorlist

Add unit tests for SENSORS

Mario Behling · Answer 1 · Thu Jun 04 2020 01:22:50 GMT+0800 (China Standard Time)

This would be great. We would also like to invite you to our weekly meeting at 5 pm CET on Saturdays to discuss details and find out how we could involve you more. Please join the call here https://meet.jit.si/fossasia-hw

Alexander Bessman · Answer 2 · Fri Jun 05 2020 21:59:55 GMT+0800 (China Standard Time)

Thanks for the invite! I might not be able to join tomorrow though. If not, I'll join next week.

CodingKnight4 · Answer 3 · Sat Oct 31 2020 23:40:34 GMT+0800 (China Standard Time)

hi everyone,
can i work with you guys
I am a beginner here.
you can assign me any task

Alexander Bessman · Answer 4 · Sun Nov 01 2020 03:26:59 GMT+0800 (China Standard Time)

Hi @BHAKTA-VARUN, tests are being added as part of the ongoing refactorization effort: #127. Unfortunately it is not really beginner friendly.

Do you have a PSLab device?

CodingKnight4 · Answer 5 · Mon Nov 02 2020 14:57:50 GMT+0800 (China Standard Time)

no sir i don't have PSLab device but thank you very much for showing concern. If in any way i can help you please let me know. I learnt python and mysql. If you require those skills please let me know. Finally, please suggest any thing which I can learn to be able to contribute. thank you

…

On Sun, Nov 1, 2020 at 12:57 AM Alexander Bessman ***@***.***> wrote: Hi @BHAKTA-VARUN <https://github.com/BHAKTA-VARUN>, tests are being added as part of the ongoing refactorization effort: #127 <#127>. Unfortunately it is not really beginner friendly. Do you have a PSLab device? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARJ5KU7GQR4GKLP7VVB6ZBTSNRQI5ANCNFSM4NRRYGSQ> .

Alexander Bessman · Answer 6 · Mon Jan 18 2021 18:49:05 GMT+0800 (China Standard Time)

Closing this since most built-in instruments now have tests.

viric · Answer 7 · Sun Jul 25 2021 21:28:59 GMT+0800 (China Standard Time)

Is it possible that tests for 'external' fail today? It seems there is outdated code. How do you run the tests currently?

Alexander Bessman · Answer 8 · Mon Jul 26 2021 16:39:06 GMT+0800 (China Standard Time)

Tests are run with tox -e playback (using recorded serial traffic, requires no hardware) or tox -e integration (requires hardware). There are only a few tests for external right now, because as you noticed most of that code is outdated. The tests that do exist are passing.