Giters

fossasia / open-event-server

The Open Event Organizer Server to Manage Events https://test-api.eventyay.com

Home Page:https://api.eventyay.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Email change links to 404

supertassu opened this issue · comments

commented

Describe the bug
When a user changes an email, the verification link leads to a 404 page.

To Reproduce
Steps to reproduce the behavior:

  1. On an existing account, go to https://eventyay.com/account/profile
  2. Change your email address to something else and submit the form
  3. Open the email sent to the new address
  4. Click on the link to verify the email address (https://eventyay.com/email/verify?token=...)
  5. Observe a 404 page

Expected behavior
The email address is confirmed and the user sees a message confirming everything went fine.

Stacktrace

Additional details (please complete the following information):

  • OS: [e.g. MacOS, Ubuntu, CentOS]
  • Python Version [e.g. 3.5, 3.6]
  • HEAD Commit hash [e.g. 4629c62]

Additional context

This seems to be coming from here:

open-event-server/app/api/helpers/mail.py

Line 516 in e3e3848

link = make_frontend_url('/email/verify', {'token': hash_})

and if I understand https://github.com/fossasia/open-event-frontend/blob/4477d408b27c026ddac6015b17a74a5370914b55/app/router.js#L302 correctly the correct url should be https://eventyay.com/verify?token=...

commented

Able to repo the issue.

Ubuntu
Python 3.8.17
HEAD = 1f76855

Can I take the issue?

Is this a regression?

commented

@mariobehling Can you please assign this issue to me I would love to work on this

commented

We don't assign issues to external contributors. Please comment that you're working on the issue after checking that no one else is, and then send a pull request for it. Thank You!