Store assets in our repository rather than calling third party services

Question

Store assets in our repository rather than calling third party services

kushthedude opened this issue 5 years ago · comments

kushthedude commented 5 years ago

Store assets in our repository rather than calling third party services, As it may tend to call too much third party services and leads to slow loading time.
Also some of the assets are not loading

Nick Jantz · Answer 1 · Thu Oct 03 2019 11:02:28 GMT+0800 (China Standard Time)

Do you have a list of third party services used or will it require combing through the current code a bit?

kushthedude · Answer 2 · Thu Oct 03 2019 13:44:59 GMT+0800 (China Standard Time)

@jantznick Thanks for your interest in the BadgeYay, Regarding the issue I just need to store image assets and license assets in our repository rather than rendering them from 3rd party websites.

Hrishikesh Suslade · Answer 3 · Thu Oct 17 2019 01:46:28 GMT+0800 (China Standard Time)

@kushthedude Can you list the which image and license assets should be stored in the repository
I would like to work on this issues

kushthedude · Answer 4 · Thu Oct 17 2019 01:49:01 GMT+0800 (China Standard Time)

See the badges used in READme and also docker svg is broken

…

On Wed, 16 Oct, 2019, 23:16 Hrishikesh Suslade, ***@***.***> wrote: @kushthedude <https://github.com/kushthedude> Can you list the which image and license assets should be stored in the repository I would like to work on this issues — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2140?email_source=notifications&email_token=AKQMTLRD2Z2AW6QSCXYOEB3QO5HPNA5CNFSM4I442O3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNLIOQ#issuecomment-542815290>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKQMTLXNZ7LUO5XSSYL3VITQO5HPNANCNFSM4I442O3A> .

Nikhil Vats · Answer 5 · Mon Oct 21 2019 18:06:56 GMT+0800 (China Standard Time)

@kushthedude I would love to work on this. I will send a PR in a day. I have a few questions -

These assets should be stored in badgeyay/frontend/public/images, right?
Where is the docker svg used which is broken?
I couldn't find any images/assets in LICENSE, where are they exactly?

Nikhil Vats · Answer 6 · Mon Oct 21 2019 19:11:19 GMT+0800 (China Standard Time)

I have sent a PR with all assets used in README stored in reposiitory. I will update it as soon as I figure out about the License assets and broken docker svg. Let me know if you have any suggestions/reviews.