#2093 breaks frontend homepage
abishekvashok opened this issue · comments
I'm submitting a ...
- bug report
- feature request
Description :
#2093 breaks the frontend home page on npm 5.6.x
Current behaviour:
#2093 breaks the frontend home page on npm 5.6.x
Expected behaviour:
It doesn't effect the frontend
Steps to reproduce:
Deploy the frontend
Screenshots
Would you like to work on the issue?
Yes
Reverting #2093
Please find the root of problem, how can a pr break anything in which only semantic ui classes are changed . Let me tell you what broke it:
- You are still using updated dependancies and npm version on local.
- I told you about 2-3 times its not this easy to jump from ember 1.0 to 3.0, many of the dependancies are obsolete and code changes are there which need to be solved manually.
- If #2093 has caused it, please state the root cause and solve it in a PR , reverting it is not solutio. Reverting PR only works when in case something is broke or build is failing due to improper review .
Thanks
You are still using updated dependancies and npm version on local.
Nope, using local ones, I can switch versions using nvm