Giters

forrestkirby / timeline-element

A custom element for the YOOtheme Pro Page Builder to render a timeline based on the grid element

Home Page:https://herzog-dupont.de/yootheme-pro-custom-elements

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

timeline breaks with yoothme pro 2.1.1

dimitrilongo opened this issue · comments

commented

hello

just after update timeline not rendering as expected, for instance no more alternate and line.

Regards

commented

Hi dimitrilongo,

I could not reproduce this problem. Have you replaced the files for the Timeline Element by the latest version as well? Make sure you first update the files for the timeline element, then update YOOtheme Pro. Also clear all cache (browser & server).

Regards
Thomas

commented

hi thanks for fast answer,

so this morning i update yootheme first, and just saw this after timeline breaks, so i download master branch, copy files, clear cache etc.

commented

I just tested the following steps and did not encounter any issue, neither after updating the template/theme nor the custom element.

  • install YOOtheme Pro 2.0.14
  • add a child theme with the timeline element
  • create a layout with the timeline element
  • update to YOOtheme Pro 2.1.1
  • update the timeline element

Please provide more details on how to reproduce this problem or an archive of your installation before the update when it was still working. Thanks.

commented

exact same steps this morning,I can send you url of the page (if yes just tell wich email adress)

commented

Do you see any error messages (PHP or JavaScript)?

If you don’t want to publicly share data on GitHub, you can create a new question (with FTP and admin access) in the YOOtheme Support Forum and provide the link to that question here. I will then take a look at the question.

commented

Thank you, I could reproduce the issue now (it’s only on WordPress). For the moment, changing line 16 of the element.php file to the following should do the trick:

$metadata->set('style:builder-hd-timeline', ['href' => Path::get('./css/timeline.css'), 'defer' => true]);

The reason seems to be that the behaviour of loading CSS files changed. In YOotheme Pro for WordPress, it’s now possible to load CSS files deferred, but not in Joomla! which results in invalid HTML markup.

I’ll get in touch with YOOtheme for a recommendation and eventually provide an update or a fix.

commented

great thanks again

commented

For the sake of documentation: This shall be fixed in YOOtheme Pro for WordPress, so once the fix has been released, the workaround won’t be needed anymore. Thus, I won’t change anything in the Timeline Element repository.