formulahendry / vscode-github-actions

GitHub Actions for VS Code

Home Page:https://marketplace.visualstudio.com/items?itemName=formulahendry.github-actions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Inline comments vs expressions

ConorSheehan1 opened this issue · comments

This seems to assumes anything after a '#' is a comment, which isn't always true. e.g. Line 10 and 12, assumes ${GITHUB_REF##*/} is a comment.

github_action_highlight

Example taken from https://stackoverflow.com/a/58034787/6305204

Unfortunately, this probably needs to be more complicated than "match": "#.*"

Since github action files are essentially yaml, maybe you could borrow from some vscode yaml extensions? e.g. https://github.com/redhat-developer/vscode-yaml/blob/d609a0f7bf987c2c3aac47720218e754a7ce9fba/syntaxes/yaml.tmLanguage.json#L160