formapro / FpOpenIdBundle

Symfony2 OpenID security extension

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incompatibility with Symfony 2.3+

tchapi opened this issue · comments

Hi,

In Symfony 2.3+ , getFlashes() has been deprecated, so in : https://github.com/formapro/FpOpenIdBundle/blob/master/Resources/views/layout.html.twig

.. you should use something like

{% for key, message in app.session.flashbag.get() %}
    <div class="{{ key }}">
        {{ message }}
    </div>
 {% endfor %}

Hope it helps
Thanks,

I am thinking about removing this logic. It is not so useful to introduce BC break.

Do you have a timeframe for updating your bundle then ? Or should I fork for a 2.3+ compatible branch ?

@tchapi since the master branch support >=2.2 version of symfony I've just updated the layout to use flashbag. Could you check this PR fixes the problem? I am not able to test it.

Yep ! All good