passthru improvement - simply allow using existing paths as passthru segments!
tlongstretch opened this issue · comments
Currently the passthru logic requires that new paths be built the entire way. However, it makes far more sense to allow it to use existing segments rather than plotting new. One question is how and when to check if a new path would be better than re-using an existing connection. If the check is not done until the road is ready to be BUILT, it means that possible passthru routes reusing existing segments might not be found because it is not possible to fit a new path between the passthru flags, which is not optimal. However, if the check is done as soon as the passthru segment end flag is found... it seems like a weird place to make the call. Typically all scoring is done in build_best_road instead of plot_road. Doing the "is this road better?" check inside plot_road seems like it might complicate things but the more I think about it seems like the clear solution.
done!