Needs namespace to prevent namespace conflicts

Question

Needs namespace to prevent namespace conflicts

snarlynarwhal opened this issue 5 years ago · comments

Just brought the scripts into my project and get a ton of compiler errors.

Andrés Leone Gámez · Answer 1 · Fri Dec 20 2019 19:54:09 GMT+0800 (China Standard Time)

I'm quite busy, so even if it is a simple and needed change, I'm not sure I will be able to do it soon. I expect I will be able to do it this weekend given how simple the change is.

PJ Legendre · Answer 2 · Sat Dec 21 2019 01:10:33 GMT+0800 (China Standard Time)

Okay, awesome! Yeah I just added a namespace for now, but figured it'd be better for you to add it to the repository so that I don't need to re-add the namespaces if I need to update the scripts in the future for whatever reason. Thanks!

If you end up not having time, I can make a PR - just let me know what namespace you'd like to use.

Andrés Leone Gámez · Answer 3 · Sat Dec 21 2019 09:38:50 GMT+0800 (China Standard Time)

I just fixed it in f81083f