fonoster / routr

⚡ The future of programmable SIP servers.

Home Page:https://routr.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG]: Compliance tests failure after removing faulty configuration in SIPp scenarios

psanders opened this issue · comments

What happened?

After removing the [last_Record-Route:] configuration from many of the UAS from SIPp scenarios, I noticed that 12/20 test failed. This is problematic, because having Record-Route in SIP responses is not standard SIP behavior, which could lead to bugs.

Steps to reproduce

Switch to the branch test/remove-record-route-from-responses and run the following command:

docker-compose -f compose.yaml -f compose.dev.yaml up

Use sngrep, wireshark, and logs to observe that many tests begin to fail.

Expected behavior

All tests should pass even without the Record-Route headers, since Record-Route should only be present in requests and not in responses.

Additional context

While working on this issue make to

  • Be able to run the compliance verification without misconfigured Record-Route
  • In addition make sure to remove unnecessary Contact header from 100 and 180 responses
  • Make sure to include Route headers only for neccessary responses

Example of failing flow:

Screenshot 2024-02-12 at 6 12 57 PM

I double-checked and confirmed that sending back a set of Record-Route is the standard behavior. Closing this issue.