Merge changes from "JWST" version by @kammerje?
vandalt opened this issue · comments
Hi @fmartinache,
Would it be OK with you if I open a PR here with changes that are not JWST-specific from @kammerje's Xara version (https://github.com/kammerje/xara/). I already opened an issue there to suggest this: kammerje#21.
Here are some examples of updates we did that might be relevant for other instruments:
- Updates to
determine_origin()andrecenter(): FPNM algorithm, optionally return dx & dy values - Hexagonal pupil model as a built-in option
- Options to load from and save to the KPFITS format as defined by Kammerer et al. (2023)
- Updated Python gitignore
At first it has a lot of JWST-specific features, but now that the JWST pipeline is on https://github.com/kammerje/jwst-kpi, it would be pretty easy to make a PR with the relevant changes only, merge them here, and have everyone using a single xara version.
Let me know what you think.
Thank you!
Hi Thomas,
if you're game, sure!
I have plans for a more streamlined xara, but they're still only plans... in the mean time, making sure that everybody uses a single xara is important.
Thanks in advance! I look forward to a time where I can spend some time working on software again :-P
Frantz.
…----- Le 4 Juil 23, à 17:10, Thomas Vandal ***@***.***> a écrit :
Hi [ https://github.com/fmartinache | @fmartinache ] ,
Would it be OK with you if I open a PR here with changes that are not
JWST-specific from [ https://github.com/kammerje | @kammerje ] 's Xara version
( [ https://github.com/kammerje/xara/ | https://github.com/kammerje/xara/ ] ).
I already opened an issue there to suggest this: [
kammerje#21 | kammerje#21 ] .
Here are some examples of updates we did that might be relevant for other
instruments:
* Updates to determine_origin() and recenter() : FPNM algorithm, optionally
return dx & dy values
* Hexagonal pupil model as a built-in option
* Options to load from and save to the KPFITS format as defined by [
https://ui.adsabs.harvard.edu/abs/2023PASP..135a4502K/ | Kammerer et al. (2023)
]
* Updated Python gitignore
At first it has a lot of JWST-specific features, but now that the JWST pipeline
is on [ https://github.com/kammerje/jwst-kpi |
https://github.com/kammerje/jwst-kpi ] , it would be pretty easy to make a PR
with the relevant changes only, merge them here, and have everyone using a
single xara version.
Let me know what you think.
Thank you!
—
Reply to this email directly, [ #5 |
view it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AEA5UUUAI7MB72RKDWIRZ5TXOQW5PANCNFSM6AAAAAAZ53Y3CA
| unsubscribe ] .
You are receiving this because you were mentioned. Message ID:
<fmartinache/xara/issues/5 @ github . com>