CI: ensure that example code is analyzed and tested

Question

CI: ensure that example code is analyzed and tested

chalin opened this issue 5 years ago · comments

Patrice Chalin commented 5 years ago

Reinstate code checks that were temporarily disabled by #2738:

Previous working build: https://travis-ci.org/flutter/website/builds/539244102
First broken build: https://travis-ci.org/flutter/website/builds/539735108 -- not that this build also failed because of a broken link (404.
First working build: https://travis-ci.org/flutter/website/builds/542865401

Code excerpts: use new tooling and infra #2233

Shams Zakhour (ignore Sfshaza) commented 4 years ago

@dnfield

Shams Zakhour (ignore Sfshaza) commented 3 years ago

Closing

Patrice Chalin · Answer 1 · Wed Apr 08 2020 02:41:16 GMT+0800 (China Standard Time)

The problem is that Travis Ubuntu uses GNU diff 3.x and macOS is still at 2.x (the macOS version is very old).

Patrice Chalin · Answer 2 · Wed Apr 08 2020 03:02:26 GMT+0800 (China Standard Time)

#3916 updates the README. Maybe you'd like a simple diff version check added to tool/refresh-code-excerpts.sh before closing this issue?

Patrice Chalin · Answer 3 · Wed Apr 08 2020 22:26:41 GMT+0800 (China Standard Time)

For the record, I did check diff behavior differences across OSs when this problem surfaced. I'm not sure why I concluded that the diff tool wasn't the issue back then. That kinda set me on a wild goose chase :-/. Anyhow, thanks to @dnfield for again suggesting that it might be a diff tool issue. Taking a second look did the trick -- actually having access to a Linux box helped make the investigation much easier!

Shams Zakhour (ignore Sfshaza) · Answer 4 · Thu Apr 09 2020 03:13:03 GMT+0800 (China Standard Time)

Can this be closed?

Patrice Chalin · Answer 5 · Fri Apr 10 2020 08:43:54 GMT+0800 (China Standard Time)

Depends if you'd like a version check added to the refresh script, for example.