flutter / samples

A collection of Flutter examples and demos

Home Page:https://flutter.github.io/samples/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`experimental/federated_plugin/federated_plugin` needs to be rebuilt for outdated Android runner

domesticmouse opened this issue · comments

@AyushBherwani1998 can you provide guidance as to what is required here?

/cc @RedBrogdon @craiglabenz

Btw, this will become a blocker at the next stable release. It's failing the linter on beta.

Hey @domesticmouse @RedBrogdon, I hope you both are doing good.

I don't know what's the reason behind the issue here exactly, I'll take a look at the jobs for this PR on weekend and hopefully send a RR if I'm able to figure out what exactly it's what we need.

Thanks Ayush. My understanding is that in the Flutter beta an old Android runner is now considered a flutter warning. This PR is to turn flutter lint warnings into build failures for beta, and is thus blocking.

I'd suggest rebuilding all the runners using the current stable release. That should be enough to silence this lint warning.

Hey @AyushBherwani1998, any chance of getting guidance on what is required to update the federated_plugin Android runner? This is now turning our beta CI red - https://github.com/flutter/samples/runs/4696765070?check_suite_focus=true

This will shortly become a blocker for the stable branch. I'm happy to help here, otherwise we may need to delete this sample.

FYI @RedBrogdon @craiglabenz

@domesticmouse should we try to rebuild the Android project and see if it passes?

Is there any specific configuration of the Android runner required in those projects? I'm happy to just refresh the runners if there is no magic involved

No, there's no specific configuration required. If refreshing the runners doesn't passes the test. I'm happy to recreate the Android project on beta channel.

I'm re-creating all of the various runners using 2.8.1. I'll send you a PR to look over soon. Thanks!