fluent-ffmpeg / node-fluent-ffmpeg

A fluent API to FFMPEG (http://www.ffmpeg.org)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update the npm package?

s1nistr4 opened this issue · comments

The NPM package hasn't been updated in 7 years and there contains a lot of ancient ES3 code , and the github repo has a lot of changes made over time. Could we get an update to it

Yep, and there is an ugly issue when trying to package anything ES that uses this library (at least when packaging with Rollup, but I guess the root problem lies within this package)

[!] (plugin rpt2) RollupError: [plugin rpt2] ./lib-cov/fluent-ffmpeg?commonjs-external: Could not resolve "./lib-cov/fluent-ffmpeg" from "./lib-cov/fluent-ffmpeg?commonjs-external"

Going to snoop around the other 300+ (!) open issues here to see if there is a solution....

I'm glad to see this project waking up, but I have a minor warning.

The update from from version 2.1.2 to 2.1.3 has a small breaking change. Version 2.1.2 works with Node 16. Version 2.13 requires Node 18+. I understand that Node 16 has reached end of life, but after 7 years perhaps there should have been a version bump to 2.2.0.

I had to change my package.json dependencies setting from

"dependencies": {
"fluent-ffmpeg": "^2.1.2"
}

TO

"dependencies": {
"fluent-ffmpeg": "2.1.2"
}