flosse / scaleApp

scaleApp is a JavaScript framework for scalable and maintainable One-Page-Applications

Home Page:http://www.scaleapp.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

i18n don't work in submodules

Aradesh opened this issue · comments

Hi.
I cant receive localization string sandbox._("searching") in submodule.

Submodule plugin used with inherit and useGlobalMediator

core.use(submodule, {
     inherit: true,
     useGlobalMediator: true
});

Localization object is

var localization = {
    en : {
        saving : 'Saving...',
        searching : 'Searching...',
        searchfinished : 'Search finished'
    },
};

In parent module calling sandbox._("searching") works fine, it return 'Searching...' string, but in submodule that registered to parent it return 'searching'

@Aradesh I'll have a look at that issue next week.

...seems to be a bug.

@Aradesh would you mind to try it again with the current master?

Now you can also use core.use(i18nPlugin,{global: localization}). See examples/submodules/app.js

@flosse, yes, now it works fine. Thanks! 👍