florianv / symfony-swap

:euro: Currency exchange rates for Symfony

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

xChangeApi.com support not allowed in Symfony configuration

jaikdean opened this issue · comments

#39 added support for xChangeApi.com, but appears to have missed the required change in Florianv\SwapBundle\DependencyInjection\Configuration, despite there being a test added for it.

The bug appears because florianv_swap configuration for xchangeapi specifies option as api-key, Service\XchangeApi.php also does so. But DependencyInjection\Configuration expects configuration to have api_keyvalue. Mismatch of option values happens.

Can you please send a PR to fix it? If it doesn't work as-is...