florianv / symfony-swap

:euro: Currency exchange rates for Symfony

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implementing cache.

stephpy opened this issue · comments

Hi,

I would like to use the awesome swap library, but i have to cache rates. I see it's done in master of florianv/swap and it's a good thing. Do you schedule to tag a new version of this library ?

If you're OK, I can make an implementation of florianv/swap with cache in this bundle.

florianv_swap:
    cache:
        doctrine: # Doctrine bundle config.
             type: array
             host: ~
             port:  ~
             instance_class: ~
             class: ~
             id: ~
    providers:
        google_finance: ~

Edit: I see you already tagged a 2.x version of swag 👍, implementation of cache on swap-bundle could result to a 2.x version on the bundle too.

Thoughts ?

Hi,

indeed, I didn't have time to update this Bundle to work with the 2.0 version of Swap.

If you're OK, I can make an implementation of florianv/swap with cache in this bundle.

It would be very nice, thanks!

Done here #2

I didn't add all providers of doctrine because it's highly coupled to doctrine ORM ...