stapi::refresh_ctable does not handle SQL generation errors

Question

mutability opened this issue 8 years ago · comments

If gen_refresh_ctable_sql returns 0 to indicate an error, refresh_ctable does not handle this and tries to execute it as SQL, which fails:

03/17/2016 12:05:15 speedtable refresh of airline_fleets failed: ERROR:  syntax error at or near "0"
LINE 1: 0
        ^

Peter da Silva · Answer 1 · Sun Apr 03 2016 23:31:33 GMT+0800 (China Standard Time)

I've got a fix for this in the stapi-fixes branch.

What was the root cause of gen_refresh_ctable_sql returning zero? I'm not seeing how that could happen without a problem elsewhere.

Oliver Jowett · Answer 2 · Mon Apr 04 2016 00:41:25 GMT+0800 (China Standard Time)

The cause was #53

Peter da Silva · Answer 3 · Mon Apr 04 2016 03:41:04 GMT+0800 (China Standard Time)

Ah, OK. This should make that kind of failure easier to debug anyway.

I'll get started on #53 - that's not a use case I had ever considered.

Peter da Silva · Answer 4 · Fri May 27 2016 21:51:31 GMT+0800 (China Standard Time)

I have rebased the stapi-fixes branch up to master. Can you please verify that it fixes this problems so I can merge it back?

Peter da Silva · Answer 5 · Mon Jul 11 2016 22:40:15 GMT+0800 (China Standard Time)

Fixed in stapi-fixes.