Toggle active/inactive states push content down

Question

Toggle active/inactive states push content down

rukshn opened this issue 2 years ago · comments

When changing the state of the toggle, the content is pushed up/down by 4px. See the attached screen recording.

nikuscs · Answer 1 · Tue Dec 13 2022 04:30:11 GMT+0800 (China Standard Time)

Thanks for the issue buddy! :) ill look into this, i believe this only happens on the preview, but im gonna have a look.

Rukshan Ranatunge · Answer 2 · Tue Dec 13 2022 10:38:07 GMT+0800 (China Standard Time)

Hi @nikuscs, unfortunately no, I was using the toggle component for my work and it also happens there. I added the recording from the preview to elaborate it. I tried going though the component but can't seem to find the cause of the issue as well.

nikuscs · Answer 3 · Tue Dec 13 2022 19:56:41 GMT+0800 (China Standard Time)

@rukshn On it! :) Should have this ready today!

nikuscs · Answer 4 · Tue Dec 13 2022 20:31:01 GMT+0800 (China Standard Time)

Oops, sorry, should be available in the next tagged release :) 0.7.11
Please let me know @rukshn

The bug happpened becasue there was no icon on the "negative" state , so when you toggle to true, it would jump to fill space for the new icon.

So now both states should have the icons as they should, there is now also a new prop "icon" that you can set to disable both icons.