flatpak / xdg-desktop-portal-gtk

Gtk implementation of xdg-desktop-portal

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

High notification priority is mapped to critical FDO urgency

ilya-fedin opened this issue · comments

The problem is at https://github.com/flatpak/xdg-desktop-portal-gtk/blob/main/src/fdonotification.c#L157-L166

Both KDE and glib map it to normal urgency:
https://github.com/KDE/knotifications/blob/4d865cd65239c5a437d61763b108d03f68701bb5/src/notifybypopup.cpp#L281-L296
https://gitlab.gnome.org/GNOME/glib/-/blob/main/gio/gfdonotificationbackend.c#L259-275

At https://docs.gtk.org/gio/enum.NotificationPriority.html high priority is described as

For events that require more attention, usually because responses are time-sensitive (for example chat and SMS messages or alarms)

Critical urgency seems too much for a chat message.