closeOnClick still requires disabling

[Mike Botsko]

We just updated to v10.0.5 from v9.x. The docs for v10 say closeOnClick now defaults to false, however in our tests that's not true.

With it set to false like the following code, toasts do not close when clicked (unless they click a dismiss button). Removing this prop enables the close-on-click functionality, I can now close the toasts when clicking anywhere on them.

  <ToastContainer
    autoClose={5000}
    className={styles.notificationToasts}
    closeButton={CloseButton}
    closeOnClick={false} // removing this enables the functionality
    hideProgressBar
    newestOnTop
    toastClassName={styles.notificationToast}
    transition={slideTransition}
  />

[Mike Botsko]

How would a comment change affect actual logic? This isn't a typing issue, this doesn't work as described in the changelog.

[Mike Botsko]

Yet that PR is also changing the comment to say it defaults to false. What do you think this is fixing?

[Mike Botsko]

Don't take my questioning so personally, it seems like you didn't even read the issue because what you're pointing out has no relevance. So I asked for clarification