fjogeleit / yaml-update-action

Update YAML property with dynamic values

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue with noCompatMode and removing quotation marks

jorgepsmatos opened this issue · comments

The following is my configuration

- name: Update Image Version in the related HelmChart values.yaml
  uses: fjogeleit/yaml-update-action@master
  with:
    valueFile: 'values.yaml'
    propertyPath: 'image.tag'
    value: ${{ steps.prep.outputs.tag }}
    branch: main
    masterBranchName: main
    createPR: false
    message: 'Update Image Version to ${{ steps.prep.outputs.tag }}'
    noCompatMode: true 

The value being replaced is:

nginx.ingress.kubernetes.io/proxy-buffering: "on" into nginx.ingress.kubernetes.io/proxy-buffering: on

which breaks my application.

I tried both noCompatMode: true and noCompatMode: false and the value is replaced either way.

Seems like the issue was related with pointing to the master branch on this repo.

Changing uses: fjogeleit/yaml-update-action@master to uses: fjogeleit/yaml-update-action@main and with noCampatMode: false fixed the issue.

It still replaced the value but from nginx.ingress.kubernetes.io/proxy-buffering: "on" to nginx.ingress.kubernetes.io/proxy-buffering: 'on' which is fair enough. Closing the issue

Hey thanks for reporting, I synced master with the current Main branch