Fix the enemies attack hitbox
64kramsystem opened this issue · comments
Description
The hitbox of the enemies attack is not correct; at least 50% of the times, the enemy attacks don't land; the hitbox seems to be too small.
To Reproduce
No response
Expected Behavior
No response
Additional Context
No response
Log Messages
No response
Depends what you mean by correct but its working as intended right now, the hitbox does not line up with the enemies hands as it is a box spawned ontop of the center. This will be left till attack hitbox size and offset are defined through fighter resource files.
Is that what you mean or is there another reason the attacks dont land? The other thing that you might be noticing is that currently the "bandit" attack animations last for significantly longer due to animation, but use the same short window of active frames as the other enemy, causing them to stand there and punch for awhile after the hitbox stops being active. This is also something to be addressed in resource file definitions of fighters attacks.
if you run witn --features=debug you can see the places where the larger green box is spawned ontop of the enemy, those should be the only times that an attack is active, if it doesn't hit within that window then it is indeed a bug.
Depends what you mean by correct but its working as intended right now, the hitbox does not line up with the enemies hands as it is a box spawned ontop of the center. This will be left till attack hitbox size and offset are defined through fighter resource files.
It's a bit strange. It seems that there are very slight differences, that cause hits to miss, when it seems that they should have landed. It seems that his happens in particular to the slinger (not 100% sure on this, though).
I've made a video:
record-2022-07-27_00.36.31.mp4
There are a few instances of misses, one is for example at 0'37". Maybe it's something difference, for example, the Z coordinate
I'll check with the hitboxes enabled
Okay thanks for the video, this is indeed what I pointed out above, both enemies currently use the same attack hitbox and frame properties. The hitbox does not line up with the attacks but I left it that way intentionally. I can quickly make the hitbox bigger before release to close this out but ultimately this will be addressed in #157.
Okay thanks for the video, this is indeed what I pointed out above, both enemies currently use the same attack hitbox and frame properties. The hitbox does not line up with the attacks but I left it that way intentionally. I can quickly make the hitbox bigger before release to close this out but ultimately this will be addressed in #157.
I see. Thanks! That actually makes... the player easier to kill, which is something a bit hard right now