fireice-uk / xmr-stak-amd

Monero AMD miner

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Failure to acquire mutex lock

Voltra opened this issue · comments

commented

std::unique_lock<std::mutex>(job_mutex);

std::unique_lock<std::mutex>(job_mutex);

std::unique_lock<std::mutex>(job_mutex);

The lines of code above actually default initialize a local std::unique_lock<std::mutex> named job_mutex instead of creating a lock on the job_mutex member.

You should look for occurences of std::unique_lock<std::mutex>( in the codebase for similar bugs.

commented

See this CppCon 2017 talk for reference: https://youtu.be/lkgszkPnV8g?si=NSm2AemA2FiRso8k&t=1946