[tree] detect itemHeight

Question

jasonLaster opened this issue 7 years ago · comments

The tree component assumes itemHeight will be passed in. The problem is that the height often changes and is then wrong.

It would be great if the tree could calculate the itemHeight when it mounts.

Nicolas Chevobbe · Answer 1 · Mon Jan 22 2018 16:09:39 GMT+0800 (China Standard Time)

we don't have itemHeight anymore.
It was used to do some virtualization but wasn't used.
What is the original issue ?

Jason Laster · Answer 2 · Mon Jan 22 2018 21:56:57 GMT+0800 (China Standard Time)

that the heights are not accurate when you scroll because we were using the wrong value for itemHeight :)

Nicolas Chevobbe · Answer 3 · Mon Jan 22 2018 22:42:46 GMT+0800 (China Standard Time)

I am pretty sure we do not set the height of elements on the Tree component.
Here's how we handle scrolling :

Nicolas Chevobbe · Answer 4 · Thu Feb 08 2018 16:25:02 GMT+0800 (China Standard Time)

Closing this as INVALID, feel free to re-open it if you think I'm wrong :)