Remove webSocketConnection option

Question

Remove webSocketConnection option

AnshulMalik opened this issue 6 years ago · comments

We no longer need firefox proxy since we can just use sockets now. So we can get rid of webSocketConnection and the code related to this option.

It is currently used at these places: https://github.com/devtools-html/devtools-core/search?utf8=%E2%9C%93&q=webSocketConnection&type=

Charles Stocky commented 6 years ago

/claim

Charles Stocky · Answer 1 · Mon Dec 31 2018 04:40:18 GMT+0800 (China Standard Time)

I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used?

Anshul · Answer 2 · Mon Dec 31 2018 05:23:01 GMT+0800 (China Standard Time)

Yes, that's right. Assume that sockets will always be used. So no longer need to check.

…

On Mon, Dec 31, 2018, 02:10 Charles Stocky ***@***.*** wrote: I'm interested in working on this. My understanding: webSocketConnection evaluates to true, should I alter the code with the assumption that websockets will always be used? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHdZvZ8fh2tIz65TuJWa6sh5nEBDPlJzks5u-SSygaJpZM4ZjiAO> .

claim · Answer 3 · Tue Jan 01 2019 04:07:18 GMT+0800 (China Standard Time)

Thanks for claiming the issue! 👋

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

Anshul · Answer 4 · Sun Jan 20 2019 02:34:36 GMT+0800 (China Standard Time)

Hey @chrlsstcky Do you need any help on this? Please feel free to ask in slack.