Firefox 117 generated faulty HAR with the bidi exporter

Question

Firefox 117 generated faulty HAR with the bidi exporter

soulgalore opened this issue a year ago · comments

Hi,
one of my test cases stopped to work updating to Firefox 117.

Dropping it into har viewer gives me this:

And looking in the HAR headers looks like this (checkout the type):

"entries": [
      {
        "request": {
          "bodySize": null,
          "method": "GET",
          "url": "https://en.wikipedia.org/wiki/Main_Page",
          "httpVersion": "h2",
          "headers": [
            {
              "name": "Host",
              "value": {"type": "string", "value": "en.wikipedia.org"}
            },
            {
              "name": "User-Agent",
              "value": {
                "type": "string",
                "value": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/117.0"
              }
            },
            {
              "name": "Accept",
              "value": {
                "type": "string",
                "value": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8"
              }
            },
...

This didn't happen with 116.

Attaching an example HAR.

browsertime.har.zip

Julian Descottes · Answer 1 · Fri Sep 01 2023 15:31:14 GMT+0800 (China Standard Time)

Ah thanks for the heads up we did a non backward compatible change on the network events, around the headers and cookies format. I can put up a patch later today, sorry about this!

…

On Fri 1 Sep 2023 at 07:24, Peter Hedenskog ***@***.***> wrote: Hi, one of my test cases stopped to work updating to Firefox 117. Dropping it into har viewer gives me this: [image: Screenshot 2023-09-01 at 07 20 39] <https://user-images.githubusercontent.com/540757/264930580-7b7fa961-3ab3-48e3-9038-ac03fe1854af.png> And looking in the HAR headers looks like this (checkout the type): "entries": [ { "request": { "bodySize": null, "method": "GET", "url": "https://en.wikipedia.org/wiki/Main_Page", "httpVersion": "h2", "headers": [ { "name": "Host", "value": {"type": "string", "value": "en.wikipedia.org"} }, { "name": "User-Agent", "value": { "type": "string", "value": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/117.0" } }, { "name": "Accept", "value": { "type": "string", "value": "text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,*/*;q=0.8" } }, ... This didn't happen with 116. Attaching an example HAR. browsertime.har.zip <https://github.com/firefox-devtools/bidi-har-export/files/12494630/browsertime.har.zip> — Reply to this email directly, view it on GitHub <#19>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIWWLSJYD5N5ZB4TYHFENLXYFWRDANCNFSM6AAAAAA4HBHNMU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Julian Descottes · Answer 2 · Sat Sep 02 2023 00:45:38 GMT+0800 (China Standard Time)

@soulgalore let me know how pressing this is. The fix in #20 is straightforward, so if needed I can publish the version early. Otherwise I'll wait for review from peers.

Thanks

Peter Hedenskog · Answer 3 · Mon Sep 04 2023 14:29:31 GMT+0800 (China Standard Time)

Thanks @juliandescottes that would be great, then I can roll out tests on Firefox 117 :)

Julian Descottes · Answer 4 · Mon Sep 04 2023 21:23:30 GMT+0800 (China Standard Time)

I thought I commented already, but @soulgalore you can try v0.0.12, it should fix the issue hopefully (but should still work with older Firefox versions)

Peter Hedenskog · Answer 5 · Tue Sep 05 2023 14:02:26 GMT+0800 (China Standard Time)

Thank you @juliandescottes for fixing this so fast! :)