firedrakeproject / gusto

Three dimensional atmospheric dynamical core using the Gung Ho numerics.

Home Page:http://firedrakeproject.org/gusto/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't use wrapper or limiter options with physics yet

tommbendall opened this issue · comments

Trying to use a wrapper or limiter option with a physics scheme will likely not work.

The evaluate method for the physics scheme generally requires an input X which is in the whole mixed function space.

However wrapper/limiter options only work with a time discretisation that is evolving a single prognostic variable.

For instance to use the recovered wrapper with a physics scheme, we'd need to be able to specify the recovery options for all of the variables involved. Probably this means enhancing the wrappers.

Thanks to @ta440, this has now been addressed through #471 and #459