Giters

firebase / snippets-android

Android snippets for firebase.google.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

startActivityForResult depricated

shrirampanchal opened this issue · comments

commented

Since startActivityForResult depricated how to target GoogleSignIn for new android versions

commented

May get around to this later, but wanted to post the relevant links that show up for fixing this and the areas I found the problem in.

snippets-android/auth/app/src/main/java/com/google/firebase/quickstart/auth/GoogleSignInActivity.java

Line 128 in 7268f81

startActivityForResult(signInIntent, RC_SIGN_IN);

snippets-android/auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/GoogleSignInActivity.kt

Line 100 in 7268f81

startActivityForResult(signInIntent, RC_SIGN_IN)

Links:
https://developer.android.com/training/basics/intents/result
https://stackoverflow.com/questions/62671106/onactivityresult-method-is-deprecated-what-is-the-alternative

commented

@MatthewFallon Let me know if you still wish to contribute :)

commented

Hey @thatfiredev is it to late to contribute ?

commented

@yveskalume I'm looking at our docs for Google Sign-in, and it seems like they have been updated for One Tap Sign-in and we no longer use startActivityForResult, so this should no longer be an issue. 🥲