IE11 Object.values missing

Question

IE11 Object.values missing

eugeneoshepkov opened this issue 4 years ago · comments

Evgeny Oshchepkov commented 4 years ago

Are you submitting a bug report or a feature request?

Bug in IE11

What is the current behavior?

#290 introduced usage of Object.values, which is not supported by IE11.

Proposed solution

Instead of Object.values(dirtyFieldsSinceLastSubmit).some(value => value)

Do Object.keys(dirtyFieldsSinceLastSubmit).some(key => dirtyFieldsSinceLastSubmit[key])

Adrian · Answer 1 · Thu May 28 2020 19:16:25 GMT+0800 (China Standard Time)

IE11, really? Why are you using/supporting that? :) (maybe just polyfill it on your side? unless IE11 support is mentioned somewhere in the final-form docs)

Evgeny Oshchepkov · Answer 2 · Thu May 28 2020 19:33:06 GMT+0800 (China Standard Time)

Business requirements. Polyfill will add unnecessary page load, increasing parsing & execution time.

Gert Dreyer · Answer 3 · Fri Mar 03 2023 03:51:17 GMT+0800 (China Standard Time)

@ThiefMaster agreed.
Those business requirements are wrong :-)
IE11 is unsupported and adding an IE11 polyfill to support less than 0.6% of users (https://browserslist.dev/) in a widely used library is wasteful and irresponsible.