Getting PHP Parse error when running the package in PHP 5.6.40 version
AmraniCh opened this issue · comments
Whoops is supposed to work without any problems in PHP ^5.5.9 versions as indicated in the composer.json file, I've run Whoops in a PHP 5.6.40 CLI and I've got this error.
PHP Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/amranich/Desktop/ajax-dispatcher/vendor/filp/whoops/src/Whoops/Exception/FrameCollection.php on line 181
If you planning to not support PHP 5 anymore then the composer.json must be updated and I think a lot of things must be changed too, if not I can create a PR to remove the return type declaration that causes this error.
Your error message does not seem to point to something from the Whoops project.
@SvenRtbg Thanks for your notice, I've updated the error.
Yes, now it makes sense, and it looks like the offending code was added just two weeks ago. See #706 .
Seems like there is at least a loophole in the test infrastructure now. TravisCI.org stopped working months ago, some transition has to be made to TravisCI.com - and that's where PHP5 relates tests would be running. The Github checks integration is only validating PHP 7.
Thank you folks for noticing and investigating! Now fixed in 9814ccd, 2.14.4.