Refactor: Change visibility of methods, structs and variables

Question

Refactor: Change visibility of methods, structs and variables

filhodanuvem opened this issue 3 years ago · comments

In golang, every identifier which starts with a uppercase letter is visible outside of the package. There are a lot of exported variables/methods/structs in gitql that should be visibile only inside the package.

Marlon Emmerich · Answer 1 · Wed Oct 13 2021 06:49:10 GMT+0800 (China Standard Time)

Hello, Claudson! It's me, Marlon! From the issue with the Hotmart hahah
We're really in a small world hahah
I can help with this, if you want!

Cya!

Claudson Oliveira · Answer 2 · Wed Oct 13 2021 06:54:17 GMT+0800 (China Standard Time)

Hey Marlon! Good to see you here. This is a quite broad issue, so feel free to make as much changes as you can! Thank you in advance.

Marlon Emmerich · Answer 3 · Wed Oct 13 2021 06:55:49 GMT+0800 (China Standard Time)

Perfect, I will hahah

Thanks a bunch!

Marlon Emmerich · Answer 4 · Mon Nov 01 2021 05:52:39 GMT+0800 (China Standard Time)

Hello, Claudson!
I'm sorry, i'm little late hahah
Can you check my PR if it's what you have in mind?
#138

If you have any suggestions, please, let me know!
Thank you again for this opportunity!

Claudson Oliveira · Answer 5 · Mon Nov 01 2021 06:17:21 GMT+0800 (China Standard Time)

All good there :) thank you