filecoin-project / go-fil-commp-hashhash

A hash.Hash implementation of fil-commitment-unsealed

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Installation is impossible under 1.17

parkan opened this issue · comments

the go get example in README does not work in modern go:

go get: installing executables with 'go get' in module mode is deprecated.
	Use 'go install pkg@version' instead.
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.

ok, so then we try the suggested way:

go install: github.com/filecoin-project/go-fil-commp-hashhash/cmd/stream-commp@latest (in github.com/filecoin-project/go-fil-commp-hashhash/cmd/stream-commp@v0.0.0-20210716094257-d9e25dd4bb3d):
	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

this line blows up:

replace github.com/filecoin-project/go-fil-commp-hashhash => ../../

which tbh I don't understand, we are already in that module?

see details in golang/go#40276

ok I removed the replace directive and everything works fine, can we take it out @ribasushi ?