file-icons / atom

Atom file-specific icons for improved visual grepping.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Styling conflict with `tool-bar-atom` package

Macko-pp opened this issue · comments

When I toggle the icons, the toolbar provided by Atom Toolbar is messed up and some of the icons in the toolbar are thicker or just a square. I don't know why this happens but I hope it's fixed soon. Apart from that, great extension, I've been using it since I downloaded Atom.

Without extension:Figure 1
With extension:Figure 2

Is this the package you're referring to? It hasn't been updated in maaaaaaaaaaaany years, and I'm surprised it's even working for you. 🤔 Hell, when I install it, I don't see anything resembling a toolbar:

Figure 1

… which brings me to my next question: what version of Atom are you running? Also, what packages do you have installed? If you're unsure where to gather this intel, run this from the terminal:

$ atom --version
Atom    : 1.58.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

$ apm ls -ib
file-icons@2.1.47
atom-toolbar@0.1.6

Your toolbar isn't working because the atom-toolbar package itself only ads the functionality, to be able to show the toolbar you need to install one that adds the functions.
image
(also thanks for the terminal commands it was very helpful)

Your toolbar isn't working because the atom-toolbar package itself only ads the functionality

Actually, it wasn't working because I had the wrong package. 😉 The correct name is tool-bar-atom and/or tool-bar.

I haven't installed most of those other packages, but what I'm seeing so far looks fine in atom-light-ui (my usual theme), but botched in seti-ui:

Atom Light UI

Figure 1: Atom Light UI

Seti UI

Figure 2: Seti UI

This leads me to believe there's another package (or theme) interfering with the icon styling. Could I trouble you to bring up the inspector tools for me, and inspect the styling applied to a botched icon?

Figure 3

After clicking on the guilty <style> tag (step 2 above), you should see the <style /> element highlighted in the DOM tree, with a source-path attribute hopefully pointing to the file inside the responsible package. For example:

Figure 4

You're right! I did what you said and it displayed this:
image

So then I thought, "that's weird, isn't that the tool-bar package?", so I disabled it and then enabled it again and suddenly it got fixed!
(I also tried changing themes before but that didn't work)

Thank you very much for your time and for your great toolbar!

You might want to file an issue at the tool-bar package's repository upstream. This package only supplies icons and some intelligent filetype detection under-the-hood. 😉

In any case, there's nothing else I can do on my end to ameliorate this, so I'm closing this. Don't hesitate to ask if you still need help with something, however. 👍