getRules returns rules lowercased

Question

getRules returns rules lowercased

BradleyStaples opened this issue 9 years ago · comments

Our CSS uses camelCased selectors, but the stdout outputted from critical.js > getRules() returns all lowercased selectors, so the majority of our CSS fails to match in the window.document.querySelector() statement in criticalrunner.js.

I'm unsure if this is something from phantomJS or what else is the source cause of the issue at this point.

Bradley Staples · Answer 1 · Fri May 01 2015 06:38:23 GMT+0800 (China Standard Time)

Thinking this is a phantomJS bug, although I'm not 100% sure. In case it is, I opened an issue over there as well. ariya/phantomjs#13197

Jeremy Wagner · Answer 2 · Sun Jan 10 2016 13:06:39 GMT+0800 (China Standard Time)

This is still going on in the CLI version as of 2016. Are there any plans to fix this?

M Somerville · Answer 3 · Sun Mar 27 2016 06:25:34 GMT+0800 (China Standard Time)

Just been bitten by this, wondered for ages why my form (ID ending in "Form") had lost its critical style :)

Jeff Whelpley · Answer 4 · Sat Aug 20 2016 00:53:30 GMT+0800 (China Standard Time)

FYI to all here I just submitted a PR to fix this issue. The problem was that the DOM API to pull the styles will for some reason always be lower case unless you include the HTML5 doctype in the document:

<!DOCTYPE html>
<html>
  ...
</html>