Giters

fieldOfView / Cura-MeasureTool

Cura plugin which adds a tool for measuring parts of models

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Attribute check ShiftModifier

jellespijker opened this issue · comments

commented

I noticed during the plugin review for the SDK 8.0 upgrade that you use a try and catch block, isn't it more efficient to check with a hasattr check. You could also consider moving the check out of the event function completely. Since this is only done for the for pyqt6 switch

Cura-MeasureTool/MeasureTool.py

Line 196 in d57aafe

try:

commented

I've been told that it is better to ask for forgiveness than to ask for permission (in Python). But is is certainly a better idea to ask for forgiveness only once. Thanks!

commented

better to ask for forgiveness than to ask for permission

This holds for most things in life, not just Python ;-)