fidelity / mab2rec

[AAAI 2024] Mab2Rec: Multi-Armed Bandits Recommender

Home Page:https://fidelity.github.io/mab2rec/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Errors for "NoReturn" type

SaraEkmanSVT opened this issue · comments

commented

The NoReturn type is used in these places:

"NoReturn" is meant to be used to end further processing, for example when calling exit(). The functions above returns nothing (explicitly) but are not meant to end the program, which results in editor warnings about code after this being unreachable. What you might want to use instead is the None type, i.e.: func() -> None instead of func() -> NoReturn

Hi @SaraEkmanSVT , thank you for pointing it out, you are absolutely correct! We have noticed this too, but never had the chance to get to it..