fidelity / kraan

Kraan is a Kubernetes Controller that manages the deployment of HelmReleases to a cluster.

Home Page:https://fidelity.github.io/kraan/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

hard code kraan-controller in template but build kraan/kraan-controller-prerelease:v0.1.20-dev

nab-gha opened this issue · comments

We hard code kraan-controller in

image: {{ .Values.kraan.kraanController.image.repository }}/kraan-controller:{{ .Values.kraan.kraanController.image.tag | default .Chart.AppVersion }}

but in ci we build kraan/kraan-controller-prerelease:v0.1.20-dev, seems we should have a value to override this so we can use that build?

Am I missing something?

@saada thoughts

You're absolutely right. I'll create a PR to fix this.