Improve code quality for SkyWallet contrib plugin for v1
olemis opened this issue · comments
Olemis Lang commented
Is your feature request related to a problem? Please describe.
SkyWallet signer PR #253 for #139 was rushed to meet v0.27.0
deadline. Some code quality items were not enforced.
Describe the solution you'd like
-
RenameRemovePersistibleSet
- Wrong condition check
-
FIXME
comment inwalleModel.data
- Revert type of
WalletDirectory.wltService
,core.PersistibleSet
=>SkycoinLocalWallet
- Remove
WalletDirectory.SetWltService
Additional context
Original work developed in PR #253 for #139 . More details in open review