Giters

fharper / coffeechat

List of awesome people offering their time for free to have a "coffee chat" with others about different topics, mostly in a mentorship kind of way.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect links in README-TEMPLATE.md

victoriacheng15 opened this issue · comments

commented

Links in README-TEMPLATE.md lead to the 404 error page

  • people.json and schema.json under Add yourself to the list
  • people.json under Remove yourself from this list

Links should not have /scripts in

e.g.
https://github.com/fharper/coffeechat/blob/main/scripts/people.json

should be
https://github.com/fharper/coffeechat/blob/main/people.json

commented

Good point, I didn't care much as README-TEMPLATE.md is used to generate README.md which have the right path for people.json, but I can make it work for both by putting the full URL instead of just the filename as a path. Thanks :)

commented

Ah, I see! Just wanted to make sure the links are correct in the end!

TGIF! :D