Question about need for "DevSender"

Question

Question about need for "DevSender"

arggh opened this issue 7 years ago · comments

I have been using FiLog with a custom sender when in development mode, "DevSender", which will log to the console, but only produces one line per log event. This way my console doesn't get obfuscated by the 30-50 lines-per-entry log messages.

It's just a minor difference compared to the ConsoleSender, but I was wondering if it's useful or different enough to be added?

Frédéric G. MARAND · Answer 1 · Sun Dec 10 2017 18:19:44 GMT+0800 (China Standard Time)

Sounds interesting: since it's essentially an extension of the ConsoleSender, it looks like it could be merged into it as an option, doesn't it ?

arggh · Answer 2 · Sun Dec 10 2017 19:08:08 GMT+0800 (China Standard Time)

Sure, I'll try to work in a PR. Do you have an idea how this option should be specified?

Frédéric G. MARAND · Answer 3 · Sun Dec 10 2017 19:38:36 GMT+0800 (China Standard Time)

Senders take their options in their constructor (look at SyslogSender for an example: https://github.com/FGM/filog/blob/master/src/Senders/SyslogSender.js#L45 ). Just be sure to provide defaults matching the current behavior when no options are passed.