rustfmt juice and coaster
crackcomm opened this issue · comments
I can provide pull request but you might want to do it yourself so you don't have to review it.
Code base would be much cleaner, easier to read, thank you.
What exactly are you suggesting? cargo fmt run? I tried to avoid it due to a huge changeset just for formatting, but I am with you, that it has to happen.
Yes, I would also suggest creating CI rules to check for formatting.
That is mostly a task for the mergebot that deals with this as a post merge step and then ammends into the merge commit.
Not sure about individual commits, but I guess that would be an option too to just do the same on a per commit basis.
Another thing to consider is, that certain macros are really hard to read with default formatting with forced lin breaks, so the first step would be to figure out a config that does not change too much of the currrent style. I am mostly looking at max-line-lnegth (or however that parameter is called).
@crackcomm I'd be happy to review + test PRs
Ok, what the resolution, we creating linters or submitting PRs with cargo fmt I would prefer both?
Both, CI ist mostly dormant now and it's pipes suffered a bit from bitrot, that's my next TODO