ff14-advanced-market-search / saddlebag-with-pockets

This is the Frontend for the FF14 Marketplace

Home Page:https://saddlebagexchange.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BUG: need to have 2 options for allagan-data columns

cohenaj194 opened this issue · comments

It seems allagan tools is now also showing the option total quantity available instead of quantity and inventory location instead of location

The api works with both and we need the frontend to just accept the other column names as being acceptable

New plugin columns
image

Old column names
image0

Can you provide an example of both valid data input options? I forget how this works 😅

Can you provide an example of both valid data input options? I forget how this works 😅

I think the issue is somewhere in this check where it requires that the input keys be location and quantity, the issue is that in some foreign language versions of the tool the keys are instead total quantity available and inventory location so we need to make both cases be acceptable.

The api reads location or inventory location as the same thing and total quantity available or quantity as the same thing. What needs to change is that if the api doesnt find location but does find inventory location it needs to use the value for inventory location as the location. The same goes for the quantity key.

Here is an example where the data can show up with the keys total quantity available and inventory location:

[
  {
    "id": 4868,
    "icon": 25218,
    "name": "Gizar-Blatt",
    "type": "NQ",
    "total quantity available": 143,
    "source": "Burle Mule",
    "inventory location": "Bag 1 - 1"
  },
  {
    "id": 8165,
    "icon": 25207,
    "name": "Krakkagemüse",
    "type": "NQ",
    "total quantity available": 140,
    "source": "Burle Mule",
    "inventory location": "Bag 1 - 2"
  },
  {
    "id": 5327,
    "icon": 21605,
    "name": "Naturbelassenes Leinen",
    "type": "NQ",
    "total quantity available": 2,
    "source": "Burle Mule",
    "inventory location": "Bag 1 - 15"
  },
  {
    "id": 5066,
    "icon": 20812,
    "name": "Elektrum-Barren",
    "type": "NQ",
    "total quantity available": 1,
    "source": "Burle Mule",
    "inventory location": "Bag 1 - 16"
  }
]

or it can be the old way with location and quantity

[
  {
    "id": 4868,
    "icon": 25218,
    "name": "Gizar-Blatt",
    "type": "NQ",
    "quantity": 143,
    "source": "Burle Mule",
    "location": "Bag 1 - 1"
  },
  {
    "id": 8165,
    "icon": 25207,
    "name": "Krakkagemüse",
    "type": "NQ",
    "quantity": 140,
    "source": "Burle Mule",
    "location": "Bag 1 - 2"
  },
  {
    "id": 5327,
    "icon": 21605,
    "name": "Naturbelassenes Leinen",
    "type": "NQ",
    "quantity": 2,
    "source": "Burle Mule",
    "location": "Bag 1 - 15"
  },
  {
    "id": 5066,
    "icon": 20812,
    "name": "Elektrum-Barren",
    "type": "NQ",
    "quantity": 1,
    "source": "Burle Mule",
    "location": "Bag 1 - 16"
  }
]