Multiple entries not being added

[Luis G. Gómez]

Hi,

I'm not sure why this does not work but only the last entry actually gets added.

var currentPrototypes = fs.readdirSync(path.join(__dirname, '..', 'prototypes'));
currentPrototypes.forEach(function(prototype){
    console.log(prototype);
    hostile.set('127.0.0.1', prototype + '.ux.localhost', function (err) {
      if (err) {
        console.error(err);
      } else {
        console.log('set /etc/hosts successfully!');
      }
    });
});

Where currentPrototypes is a list of subfolders in the prototypes directory.

Also, if I run it again, it adds another identical entry where it should fail silently.

Any ideas?

Thank you,

[Feross Aboukhadijeh]

You need to wait until the callback has fired before calling hostile.set again, or else you will be doing multiple writes at the same time to the same file, which means that only the last write will win.

You might consider using a library like run-series to help you with this.

Perhaps hostile should support expose a function that takes multiple values and uses run-series internally. PR welcome :)