fergiemcdowall / norch

A search server that can be installed with npm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should we get rid of unneccesary use of this in norch.js?

mewwts opened this issue · comments

I will take a look at this. Just need the tests to pass first.

What was the purpose of exposing all those variables in the first place? Something about instantiating several Norches?

There was some wierdness when instantiating norches from the command line. All the older norches would always switch over to the newest norches datastore. This is covered in the tests, so since the tests are passing, Im going to stick my neck out and say that it is fixed

...and fixed without unnecessary thisification, thanks to your PR

this.shouldberemoved();