fer / ion-tree-list

Ionic directive for displaying nested list items.

Home Page:http://fer.github.io/ion-tree-list/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Hangs when loading 1000+ nodes

joshjohn1984 opened this issue · comments

the tree hangs when the total nodes sent to it are 1000+.

commented

I've updated the example website to add extra nodes and test what you are reporting. I am pretty sure there is a lot to say about performance here, but I don't experience this issue in my browser:
screen shot 2016-03-13 at 4 38 01 pm

Could you please @joshjohn1984 provide a bit more info and confirm it still happens?

commented

@joshjohn1984: did you have any chance to check this new example where you can display thousands of items?

Don't hesitate to report any issue as new thoughts. Thanks.

Dear @fer

I have a similar problem over loading 1000+ nodes. While it didn't hang on my test but it took a long time (~7 seconds) to load the tree and my requirements didn't allow this. So, I took the liberty to fork your project and re-write to load the nodes only when the nodes is clicked open by a user. The result is a faster rendering for the interactive user. However, since my requirements are different and the method of loading is different, I decided to call it ion-dynamic-tree-list and share it on github. You can go here to take a look. While I took a lot from your code, I added an "Acknowledgment" section for your work. Thanks.

commented

Hi @ltung I've taken a look at your code and it looks good. I'd have loved it if you had contributed to this same repo instead though.

Since your approach is a bit different when loading/displaying items, I'll try to comment on your repo as much as possible always considering our mutual contributions in the future.

BTW: I've also noticed issues cannot be created on your repo. I wanted to create an issue for you to create an online example (so we can benchmark, compare and improve). @joshjohn1984 might find it useful too.

Hi @fer, Thanks for your comment. "Issue" section has been fixed.