felixge / httpsnoop

Package httpsnoop provides an easy way to capture http related metrics (i.e. response time, bytes written, and http status code) from your application's http.Handlers.

Home Page:https://godoc.org/github.com/felixge/httpsnoop

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Does new ResponseController have to be supported by this package?

mitar opened this issue · comments

commented

Go 1.20 added ResponseController: golang/go#54136

I think we could just add Unwrap to every struct returned by this package. This could allow that any future extension by http package would just continue to work with this package. This package can then eventually generate extension methods as well, but Unwrap is nice to have.

I think the new ResponseController should be handled, thanks for bringing this up. PRs welcome!