felixfontein / ansible-acme

An Ansible collection for managing TLS certificates with ACME CAs like Let's Encrypt.

Home Page:https://galaxy.ansible.com/ui/repo/published/felixfontein/acme/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Task Wait for DNS entries to propagate not stable

mr-ssd opened this issue · comments

The task named "Wait for DNS entries to propagate" in role acme_certificate is not stable when using with Route53.

I suggest we should change wait: false to wait: true to wait until the changes have been replicated to all Amazon Route 53 DNS servers before we check for the TXT record.

Using wait: true is not a good solution either, since that makes the role incredibly slow when using Route53.

Can we change it as an option in a variable?

I would prefer not to add a config for that. I started some work in the aws collections to make it possible to solve this in a cleaner way: ansible-collections/amazon.aws#1683 ansible-collections/community.aws#1904

@felixfontein thank you for the update. Should this case be closed?

I would keep this issue open, as the problem hasn't been resolved yet.

ansible-collections/community.aws#1904 together with #62 fixes this, and is pretty efficient as well. I tested it this morning with a larger set of certificates (many of them with Route 53 DNS validation), and it worked as expected.